Pass bigquery job object to get_job #1844
Conversation
Signed-off-by: Lars Klingen <[email protected]>
LarsKlingen
requested review from
achals,
tsotnet,
woop and
a team
as code owners
|
Hi @LarsKlingen. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1844 +/- ##
==========================================
- Coverage 84.45% 84.45% -0.01%
==========================================
Files 90 90
Lines 6773 6772 -1
==========================================
- Hits 5720 5719 -1
Misses 1053 1053
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/assign @felixwang9817 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, LarsKlingen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR @LarsKlingen ! |
What this PR does / why we need it:
Fixes Issue 1842 of job_id not found when querying bigquery job status from outside of US.
Which issue(s) this PR fixes:
Fixes #1842
Does this PR introduce a user-facing change?: